grpc-native: Support client calls on native #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
requested changes
Aug 19, 2025
There was a problem hiding this comment.
Wow, great work! Thanks for the amount of comments and the big test set, it was very pleasant to read!
I have some comments and suggestions below, please address them before merging.
One big question that I have, is using C lib instead of C++ one - how hard it would be for use to support gRPC features as Auth, interceptors, etc? It is available is C API?
grpc/grpc-core/src/commonTest/kotlin/kotlinx/rpc/grpc/test/RawClientTest.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/commonTest/kotlin/kotlinx/rpc/grpc/test/RawClientTest.kt
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/CallbackFuture.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/CompletionQueue.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/CompletionQueue.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/NativeManagedChannel.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/utils.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/ManagedChannel.native.kt
Show resolved
Hide resolved
Mr3zee
approved these changes
Aug 19, 2025
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/CompletionQueue.kt
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/CompletionQueue.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/internal/NativeClientCall.kt
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/ManagedChannel.native.kt
Outdated
Show resolved
Hide resolved
grpc/grpc-core/src/nativeMain/kotlin/kotlinx/rpc/grpc/ManagedChannel.native.kt
Show resolved
Hide resolved
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Signed-off-by: Johannes Zottele <[email protected]>
Jozott00
force-pushed
the
grpc/service-native
branch
from
c5fd51e to
10f4c7b
Compare
Mr3zee
pushed a commit
that referenced
this pull request
Aug 21, 2025
* grpc-native: Initial client setup Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Working CompletionQueue Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Working version of NativeClientCall Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Working rewrite state Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Add callback future Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Refactor to use callbacks instead of coroutines Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Fixes after rebase Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Implement bridge to common Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Remove unnecessary C header definitions Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Rename grpcpp_c to kgrpc Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Reduce library dependencies (fixes KRPC-185) Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Write docs Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> * grpc-native: Address PR comments Signed-off-by: Johannes Zottele <[email protected]> --------- Signed-off-by: Johannes Zottele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC/Native
Solution
This PR uses the grpc-core (C) library to support client calls for Kotin/Native.